Commit Graph

2397 Commits

Author SHA1 Message Date
9b81cd1902 Fix unit test build on MSVC 64-bit (#404)
The issue stemmed from Catch's default entry point being wmain instead of main, so we just updated the configuration to expect that.
2024-08-10 22:55:06 -04:00
33f7562bfc Use a CDATA section for preferences in replays 2024-08-10 15:47:01 -04:00
4d4ab09395 Update Catch to v2.13.10 2024-08-10 15:16:24 -04:00
30e583b1d4 Address compile warnings (Xcode 12) in the editors 2024-08-10 12:58:01 -04:00
84b649a107 Fix dead store warnings from static analysis of the scenario editor 2024-08-10 12:45:35 -04:00
3931d20c4a Fix some undefined behaviour detected by static analysis in the scenario editor 2024-08-10 12:45:09 -04:00
3e331d7cfa Update PC Editor's version of give_help() to match game's version.
This fixes a dead store issue reported by the static analyzer and also addresses a now-obsolete TODO comment.
2024-08-10 12:32:41 -04:00
f400a5b7de Address a bunch of dead store issues found by the static analyzer.
Pretty much all of these fall into one of two categories:

* Variables that are obviously unneeded and in many cases completely unused – probably remnants of old code that was rewritten. These ones were deleted.

* Variables that look like they should be used but aren't. These ones have been suppressed, with a TODO message added as a reminder to investigate them in more detail later.
2024-08-10 12:22:05 -04:00
1d491e3b2a Address a dead store issue found by the static analyzer.
I kept this separate from the other dead store issues because it clearly changes behaviour – the change makes teleport_party NEVER play an animation in combat. Thus, in case the change is determined to be wrong, this is to document what happened and why.
2024-08-10 12:09:35 -04:00
104f6d6b0b Address some compiler warnings (Xcode 12)
* Missing prototypes
* Unused function parameters
* Float comparison in preferences
2024-08-10 12:06:11 -04:00
a202918d57 Address UB warnings found by the static analyzer 2024-08-10 11:56:51 -04:00
a52ce5189b Fix a bunch of undefined behaviour detected by the static analyzer in the saved game format. 2024-08-10 00:16:52 -04:00
4391d7638b Describe the Scenario Design Contest in the past tense, since it hasn't been running for years and years 2024-08-09 22:36:43 -04:00
9f67015ffe Remove the 'normal speed' icon, which had always been unused in Blades of Exile
closes #387
2024-08-09 22:32:09 -04:00
4e6306b110 record and replay mods on startup buttons. fix #394 2024-08-09 19:47:15 -04:00
f8d319c550 replay the scenario list 2024-08-09 02:16:07 -04:00
740810d7d2 record installed scenario files 2024-08-09 02:16:07 -04:00
a13e7cdc3b replace atoi with std::stoi 2024-08-09 02:06:31 -04:00
f01fdb7e2a move ui_rand to cDialog 2024-08-08 13:43:29 -04:00
fc12092a1b replace rand() and srand(). fix #390 2024-08-08 13:43:29 -04:00
a1022aa23b guard next_action_type() call 2024-08-08 08:30:59 -04:00
f54931760b print message when xmllint not available 2024-08-04 22:07:11 -04:00
0375cda714 fix xmllint check in SConscript 2024-08-04 22:07:11 -04:00
95f1225108 fix #240 2024-08-03 19:28:02 -04:00
de36bf7536 Fix #327 for windows 2024-08-03 19:27:48 -04:00
f9ccd2bb9a fix #148 2024-08-03 12:46:09 -04:00
09b2c0c822 move forward-declarations into boe.actions.cpp 2024-08-03 12:30:08 -04:00
0554149859 deque use non-const type parameter 2024-08-03 12:30:08 -04:00
bc89dad159 record and replay quitting the app 2024-08-03 12:30:08 -04:00
cc5823bbcd de-duplicate quitting logic 2024-08-03 12:30:08 -04:00
27db98a634 record/replay giving items 2024-08-03 12:30:08 -04:00
f3f1124bef record and replay dropping items 2024-08-03 12:30:08 -04:00
43350e4e09 handle several one-step actions 2024-08-03 12:30:08 -04:00
1e68d32543 DRY retrieval of some types from replay action 2024-08-03 12:30:08 -04:00
40cec6e861 move replaying into the event loop 2024-08-03 12:30:08 -04:00
d9cf1c8fae record and replay switching active PC 2024-08-03 12:30:08 -04:00
41f88c9f58 container controls replay child control clicks 2024-08-03 12:30:08 -04:00
0a3aa97b59 Fix #318 2024-08-01 23:11:27 -04:00
5b686595f3 mac don't try to install resources to excluded partial build targets 2024-08-01 20:08:09 -04:00
fc083c6fcc make function static 2024-07-31 19:58:19 -04:00
e27165683c cleaner switch declarations 2024-07-31 19:58:19 -04:00
9c1a5b98e1 led groups replay specific led click 2024-07-31 19:58:19 -04:00
9d5c2e4fe1 revert control_focus recording/replaying 2024-07-31 19:58:19 -04:00
afca0dc85d mac replay preferences 2024-07-31 19:58:19 -04:00
49c62aa985 don't replay events for empty id controls 2024-07-31 19:58:19 -04:00
0935b9ce19 allow empty string for action info element 2024-07-31 19:58:19 -04:00
e1bfea8302 mac record preferences 2024-07-31 19:58:19 -04:00
4d0806a9cf MacOS don't try to load 'record' or 'replay' 2024-07-31 19:58:19 -04:00
10ad8dc9da throw std::strings 2024-07-28 17:07:33 -04:00
4e1c228161 throw error when checking next_action_type() of null 2024-07-28 17:07:33 -04:00