openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Update PC Editor's version of give_help() to match game's version.

Browse Source 
This fixes a dead store issue reported by the static analyzer and also addresses a now-obsolete TODO comment.
This commit is contained in:
Celtic Minstrel
2024-08-10 12:32:41 -04:00
parent f400a5b7de
commit 3e331d7cfa
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/pcedit/pc.main.cpp
View File

@@ -462,12 +462,10 @@ static void give_help(short help1,short help2,cDialog* parent) {
help_forced = true;
help1 -= 200;
}
// This SDF is the "never show instant help" flag
// TODO: Expose preferences to the PC editor
#if 0
if(univ.party.stuff_done[306][4] > 0 && !help_forced)
if(!help_forced && (!get_bool_pref("ShowInstantHelp", true) || get_iarray_pref_contains("ReceivedHelp", help1)))
return;
#endif
append_iarray_pref("ReceivedHelp", help1);
append_iarray_pref("ReceivedHelp", help2);
str1 = get_str("help",help1);
if(help2 > 0)
str2 = get_str("help",help2);