openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix #230 #387

Closed
NQNStudios wants to merge 1 commits from fix230 into master
pull from: fix230
merge into: openboe:master
Conversation 11 Commits 1 Files Changed 1 +3 -24
NQNStudios commented 2024-08-03 22:03:25 +00:00 (Migrated from github.com)
Copy Link

The existence of a 0 in the status map was enough to make the speed icon render. Fixed #230 by checking >0

The existence of a 0 in the status map was enough to make the speed icon render. Fixed #230 by checking >0
CelticMinstrel commented 2024-08-03 23:32:57 +00:00 (Migrated from github.com)
Copy Link

I am not convinced that this issue even exists. The line you changed looks like the line that's supposed to put the "normal speed" icon if you're neither hasted nor slowed, and without the change it looks like it does that, unless 7 is the wrong icon?

I am not convinced that this issue even exists. The line you changed looks like the line that's supposed to put the "normal speed" icon if you're neither hasted nor slowed, and without the change it looks like it does that, unless 7 is the wrong icon?
NQNStudios commented 2024-08-04 00:00:08 +00:00 (Migrated from github.com)
Copy Link

It hadn't occurred to me that there would be a "normal speed" icon but I guess you're right.

staticons

This is the icon spritesheet and counting to 7 I see the one it draws.

So my fix was wrong... but I hate the normal speed icon and think it should be removed

It hadn't occurred to me that there would *be* a "normal speed" icon but I guess you're right. ![staticons](https://github.com/user-attachments/assets/ac432021-2ec3-4a92-86b4-2fe40fc8a605) This is the icon spritesheet and counting to 7 I see the one it draws. So my fix was wrong... but I hate the normal speed icon and think it should be removed
CelticMinstrel commented 2024-08-04 03:05:41 +00:00 (Migrated from github.com)
Copy Link

Are you able to open either of the original versions of the game, downloadable from the Spiderweb website? I theoretically can, but it seems I never copied that over from my old computer so it'll be a pain to get it booted up to try it. I'd like to know whether the "normal speed" icon actually appears in the original game, or if it was something I put back in based on remembering it in Exile 2 and 3 and seeing it on the stat icons sheet.

Are you able to open either of the original versions of the game, downloadable from the Spiderweb website? I theoretically can, but it seems I never copied that over from my old computer so it'll be a pain to get it booted up to try it. I'd like to know whether the "normal speed" icon actually appears in the original game, or if it was something I put back in based on remembering it in Exile 2 and 3 and seeing it on the stat icons sheet.
NQNStudios commented 2024-08-05 01:25:27 +00:00 (Migrated from github.com)
Copy Link

setting up DOSBOX-X/Windows 98 to check. This should come in handy for resolving other questions about how the orriginal worked

setting up DOSBOX-X/Windows 98 to check. This should come in handy for resolving other questions about how the orriginal worked
NQNStudios commented 2024-08-05 01:41:37 +00:00 (Migrated from github.com)
Copy Link

Confirmed -- there is no Normal Speed icon shown in the official version on windows.

Confirmed -- there is no Normal Speed icon shown in the official version on windows.
CelticMinstrel commented 2024-08-05 02:06:06 +00:00 (Migrated from github.com)
Copy Link

I wish I could check in Basilisk 2 as well, but… if it wasn't there on Windows, I guess the chances are it also wasn't there in the Mac version. I will probably check at some later point, though.

I wish I could check in Basilisk 2 as well, but… if it wasn't there on Windows, I guess the chances are it also wasn't there in the Mac version. I _will_ probably check at some later point, though.
NQNStudios commented 2024-08-08 17:40:14 +00:00 (Migrated from github.com)
Copy Link

I tried to get Basilisk 2 running on my silicon mac and my older model, and it wasn't launching.

I tried to get Basilisk 2 running on my silicon mac *and* my older model, and it wasn't launching.
CelticMinstrel commented 2024-08-08 17:44:40 +00:00 (Migrated from github.com)
Copy Link

Yeah, it also wasn't launching when I tried it just before posting that. I had it set up and working on the old computer, so if I can get that plugged in, I should be able to check, but that's not as easy as it sounds…

Yeah, it also wasn't launching when I tried it just before posting that. I had it set up and working on the old computer, so if I can get that plugged in, I should be able to check, but that's not as easy as it sounds…
NQNStudios commented 2024-08-08 17:45:16 +00:00 (Migrated from github.com)
Copy Link

No one will miss the "Normal Speed" icon. 😈

No one will miss the "Normal Speed" icon. 😈
CelticMinstrel commented 2024-08-10 02:29:52 +00:00 (Migrated from github.com)
Copy Link

I had the sudden realization that we could just check official screenshots. Sure enough, there's no normal speed icon.

I had the sudden realization that we could just check _official screenshots_. Sure enough, [there's no normal speed icon](https://spiderwebsoftware.com/blades/BOEshots.html).
NQNStudios commented 2024-08-10 02:35:00 +00:00 (Migrated from github.com)
Copy Link

@CelticMinstrel you can also close #230 now

@CelticMinstrel you can also close #230 now

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#387
No description provided.
Delete Branch "fix230"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?