openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Speed icon shown in party window when speed is not in any abnormal state #230

New Issue
Closed
opened 2020-01-17 03:00:52 +00:00 by x-qq · 16 comments
x-qq commented 2020-01-17 03:00:52 +00:00 (Migrated from github.com)
Copy Link

As seen on an unrelated screenshot at https://0x0.st/zh0V.png

Original Exile 3 and Blades of Exile did not show the icon when there was no haste/slowness applied.

I personally find those icons distracting/disorienting (icons in party window usually meant some abnormal state that needs attention).

Could be made into a setting maybe?

As seen on an unrelated screenshot at https://0x0.st/zh0V.png Original Exile 3 and Blades of Exile did not show the icon when there was no haste/slowness applied. I personally find those icons distracting/disorienting (icons in party window usually meant some abnormal state that needs attention). Could be made into a setting maybe?
CelticMinstrel commented 2020-01-22 04:07:32 +00:00 (Migrated from github.com)
Copy Link

Marking as a bug because original BoE didn't use this icon either on Mac or Windows (though Exile II did use it).

Marking as a bug because original BoE didn't use this icon either on Mac or Windows (though Exile II did use it).
NQNStudios commented 2024-08-28 19:26:26 +00:00 (Migrated from github.com)
Copy Link

@CelticMinstrel I don't understand... couldn't you have made this refactor without introducing a regression and re-opening an issue?

I really don't want the normal speed icon to exist. I could introduce a preference to enable/disable it, but I think the default should be that it be off. I don't think anyone wants a normal speed icon.

@CelticMinstrel I don't understand... couldn't you have made this refactor without introducing a regression and re-opening an issue? I really don't want the normal speed icon to exist. I could introduce a preference to enable/disable it, but I think the default should be that it be off. I don't think anyone wants a normal speed icon.
CelticMinstrel commented 2024-08-28 20:01:34 +00:00 (Migrated from github.com)
Copy Link

The previous fix was incomplete, so I probably would've reopened it even if I hadn't done the refactor. I already have a commit to remove it again but I haven't pushed it because CI somehow broke.

The previous fix was incomplete, so I probably would've reopened it even if I hadn't done the refactor. I already have a commit to remove it again but I haven't pushed it because CI somehow broke.
NQNStudios commented 2024-08-28 20:03:05 +00:00 (Migrated from github.com)
Copy Link

Okay, thanks for clarifying. 🙏

Okay, thanks for clarifying. 🙏
NQNStudios commented 2024-08-28 20:29:26 +00:00 (Migrated from github.com)
Copy Link

I have reproduced the linux compiler error. I thought at first it was because of a const mismatch but that wasn't the case.

I have reproduced the linux compiler error. I thought at first it was because of a const mismatch but that wasn't the case.
👍 1
NQNStudios commented 2024-08-28 20:30:55 +00:00 (Migrated from github.com)
Copy Link

Actually it might be a const error.

Actually it might be a const error.
CelticMinstrel commented 2024-08-28 20:31:29 +00:00 (Migrated from github.com)
Copy Link

That was my guess too, but when I looked at the code I couldn't see anything wrong, and it didn't happen on Mac, so I was stumped.

That was my guess too, but when I looked at the code I couldn't see anything wrong, and it didn't happen on Mac, so I was stumped.
NQNStudios commented 2024-08-28 20:33:32 +00:00 (Migrated from github.com)
Copy Link

I added a const in a different place and it recompiled everything which I thought was a good sign but then came out with the same error

I added a const in a different place and it recompiled everything which I thought was a good sign but then came out with the same error
CelticMinstrel commented 2024-08-28 20:38:41 +00:00 (Migrated from github.com)
Copy Link

My other guess was that the new file is somehow not compiled on Linux, but that can't be right, can it? I dutifully added it to the SConscript, after all.

My other guess was that the new file is somehow not compiled on Linux, but that can't be right, can it? I dutifully added it to the SConscript, after all.
NQNStudios commented 2024-08-28 20:42:37 +00:00 (Migrated from github.com)
Copy Link

It is getting compiled, but maybe not by one of the 2 editors?

It is getting compiled, but maybe not by one of the 2 editors?
NQNStudios commented 2024-08-28 20:50:24 +00:00 (Migrated from github.com)
Copy Link

living.cpp, which the error is coming from, is compiled in this group:

party_classes = Glob("#src/universe/*.cpp")

damage.cpp is compiled in this group
tools = SConscript("build/obj/tools/SConscript")

living.cpp, which the error is coming from, is compiled in this group: `party_classes = Glob("#src/universe/*.cpp")` damage.cpp is compiled in this group `tools = SConscript("build/obj/tools/SConscript")`
NQNStudios commented 2024-08-28 20:53:41 +00:00 (Migrated from github.com)
Copy Link

but tools end up in common_sources....

but tools end up in `common_sources`....
CelticMinstrel commented 2024-08-28 21:05:42 +00:00 (Migrated from github.com)
Copy Link

And so do party_classes…

EDIT: Ah, they actually don't, but they're still added in for all 4 builds.

And so do `party_classes`… EDIT: Ah, they actually don't, but they're still added in for all 4 builds.
NQNStudios commented 2024-08-28 21:09:37 +00:00 (Migrated from github.com)
Copy Link

scons game=true and scons scenedit=true work fine. only scons pcedit=true fails.

`scons game=true` and `scons scenedit=true` work fine. only `scons pcedit=true` fails.
NQNStudios commented 2024-08-28 21:11:57 +00:00 (Migrated from github.com)
Copy Link

I don't want to think about why it works now but I fixed it.

I don't want to think about why it works now but I fixed it.
NQNStudios commented 2024-08-28 21:14:14 +00:00 (Migrated from github.com)
Copy Link

#419

#419
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
bug
game
Milestone
No items
No Milestone 2.0
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#230
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?