openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

alt+start scenario records incorrectly in replays #394

New Issue
Closed
opened 2024-08-08 18:26:53 +00:00 by NQNStudios · 3 comments
NQNStudios commented 2024-08-08 18:26:53 +00:00 (Migrated from github.com)
Copy Link

I didn't realize the alt-key is significant when clicking startup buttons. need to make that replay action record its state

I didn't realize the alt-key is significant when clicking startup buttons. need to make that replay action record its state
NQNStudios commented 2024-08-08 18:29:12 +00:00 (Migrated from github.com)
Copy Link

Should probably refactor handle_startup_button_click so it takes modifiers as a parameter the way dialog click events do, instead of calling kb.isAltPressed() in its body

Should probably refactor `handle_startup_button_click` so it takes modifiers as a parameter the way dialog click events do, instead of calling `kb.isAltPressed()` in its body
CelticMinstrel commented 2024-08-09 06:05:12 +00:00 (Migrated from github.com)
Copy Link

Is alt the only modifier that's significant here? I remember there's a modifier you can hold to get the debug preset party instead of the default preset party… but now that I think of it, I guess that's in a dialog, not at startup…

Is alt the only modifier that's significant here? I remember there's a modifier you can hold to get the debug preset party instead of the default preset party… but now that I think of it, I guess that's in a dialog, not at startup…
NQNStudios commented 2024-08-09 17:21:24 +00:00 (Migrated from github.com)
Copy Link

That was the only instance of using kb in handle_startup_button_click().

That was the only instance of using `kb` in `handle_startup_button_click()`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
bug
game
replay
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#394
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?