openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

WIP: SDF Finder WIP #715

Draft
NQNStudios wants to merge 1 commits from NQNStudios/sdf-finder into master
pull from: NQNStudios/sdf-finder
merge into: openboe:master
Conversation 0 Commits 1 Files Changed 2 +36
NQNStudios commented 2025-04-06 20:48:10 +00:00 (Migrated from github.com)
Copy Link

Contexts SDFs can be used, which need to be searched:

  • the explicit sdf fields of special nodes
  • other sdf fields (see 94d9ee268f/src/scenario/special.cpp (L777) for something that needs to be done before these can be searched)
  • dialog nodes
  • SDF flag creature's life is linked to (in creature advanced details)
  • SDF flag to eliminate outdoor wandering/special encounters

...AND MORE THAT I'M NOT AWARE OF/DIDN'T THINK OF YET?

The first step I've taken towards SDF finder implementation is to make functions that will be useful for checking all of a scenario's special nodes for SDFs they reference.

Contexts SDFs can be used, which need to be searched: - [ ] the explicit sdf fields of special nodes - [ ] other sdf fields (see https://github.com/NQNStudios/cboe/blob/94d9ee268ffe199a781a22f8ca69d3d529b2196b/src/scenario/special.cpp#L777 for something that needs to be done before these can be searched) - [ ] dialog nodes - [ ] SDF flag creature's life is linked to (in creature advanced details) - [ ] SDF flag to eliminate outdoor wandering/special encounters ...AND MORE THAT I'M NOT AWARE OF/DIDN'T THINK OF YET? The first step I've taken towards SDF finder implementation is to make functions that will be useful for checking all of a scenario's special nodes for SDFs they reference.
This pull request has changes conflicting with the target branch.
  • src/scenario/scenario.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin NQNStudios/sdf-finder:NQNStudios/sdf-finder
git checkout NQNStudios/sdf-finder
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
enhancement
scenedit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#715
No description provided.
Delete Branch "NQNStudios/sdf-finder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?