openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

undo/redo should be disabled while any dialog is open #758

New Issue
Closed
opened 2025-06-13 02:23:32 +00:00 by NQNStudios · 2 comments
NQNStudios commented 2025-06-13 02:23:32 +00:00 (Migrated from github.com)
Copy Link

I don't know the simplest way to make opening any dialog disable the Undo and Redo menu items for as long as the dialog is open.

I don't think there are any situations where an editor dialog is open and it would be safe to pull or pop from the undo_list. Not to mention, with dialogs open, you can't see what changes.

I don't know the simplest way to make opening any dialog disable the Undo and Redo menu items for as long as the dialog is open. I don't think there are any situations where an editor dialog is open and it would be safe to pull or pop from the undo_list. Not to mention, with dialogs open, you can't see what changes.
CelticMinstrel commented 2025-06-13 05:01:22 +00:00 (Migrated from github.com)
Copy Link

There is an alternative option: make the edit menu undo/redo apply the active text field. Of course, that's only for dialogs that have a text field…

There is an alternative option: make the edit menu undo/redo apply the active text field. Of course, that's only for dialogs that _have_ a text field…
NQNStudios commented 2025-06-13 13:37:27 +00:00 (Migrated from github.com)
Copy Link

Lo and behold, your comment helped me figure out why copy/pasting text is broken in the scenario editor for Mac. #648

Lo and behold, your comment helped me figure out why copy/pasting text is broken in the scenario editor for Mac. #648
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
bug
scenedit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#758
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?