openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Don't display 'no item' response if another PC can shop. #679

Merged
NQNStudios merged 1 commits from heal-any-pc into master 2025-03-07 02:26:25 +00:00
Conversation 0 Commits 1 Files Changed 3 +171 -199
NQNStudios commented 2025-03-06 02:17:43 +00:00 (Migrated from github.com)
Copy Link

In comments on #669 I outlined a way to intuitively handle shopping from a healer if the active PC is fully healed. This PR implements my suggestion. I think it feels pretty good and makes shopping better even outside the case that was buggy before: it's just nice to have the shop cycle between injured PCs if you're trying to buy healing for everyone.

These are the rules:

  • If the active PC gets an empty shop, iterate from the first to last PC until finding someone who can see a shop item
    • If none can shop, show the 'no item' response
  • When the active PC buys something, if this clears out the shop, iterate from the first to last PC until finding someone who can see a shop item
    • if none can see an item, stay on the empty shop of the PC that was active when the last item was bought.
  • When shopping ends, if the shop interface was the last thing to change the player's active PC, it puts it back how it was.

Fix #669

In comments on #669 I outlined a way to intuitively handle shopping from a healer if the active PC is fully healed. This PR implements my suggestion. I think it feels pretty good and makes shopping better even outside the case that was buggy before: it's just nice to have the shop cycle between injured PCs if you're trying to buy healing for everyone. These are the rules: - If the active PC gets an empty shop, iterate from the first to last PC until finding someone who can see a shop item - If none can shop, show the 'no item' response - When the active PC buys something, if this clears out the shop, iterate from the first to last PC until finding someone who can see a shop item - if none can see an item, stay on the empty shop of the PC that was active when the last item was bought. - When shopping ends, if the shop interface was the last thing to change the player's active PC, it puts it back how it was. Fix #669
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#679
No description provided.
Delete Branch "heal-any-pc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?