Default no-items shop response is broken #669

Closed
opened 2025-03-01 04:42:18 +00:00 by CelticMinstrel · 5 comments
CelticMinstrel commented 2025-03-01 04:42:18 +00:00 (Migrated from github.com)

I think we need to reconsider this, at least in the specific case of the healing shop. Right now, you can get this response even when there is someone who needs healing, just because they happen to not be the active character. Opening a blank shop where you can then switch characters and see the available options seems more correct. But on the other hand, having this default response when there really is nothing in the shop isn't a bad thing.

I think we need to reconsider this, at least in the specific case of the healing shop. Right now, you can get this response even when there is someone who needs healing, just because they happen to not be the active character. Opening a blank shop where you can then switch characters and see the available options seems more correct. But on the other hand, having this default response when there _really is_ nothing in the shop isn't a bad thing.
NQNStudios commented 2025-03-01 13:05:14 +00:00 (Migrated from github.com)

What if the healing shop automatically switches your active character to the first one that can buy a healing item? (if the current one can't).

What if the healing shop automatically switches your active character to the first one that can buy a healing item? (if the current one can't).
CelticMinstrel commented 2025-03-01 15:40:00 +00:00 (Migrated from github.com)

Hmm… I'm not sure. If the ultimate goal is to never show an empty shop, it would also have to auto-switch once that character is healed, or possibly even auto-close. It feels like that could be annoying, but it's hard to tell without actually trying it…

Hmm… I'm not sure. If the ultimate goal is to _never show an empty shop_, it would also have to auto-switch once that character is healed, or possibly even auto-close. It feels like that could be annoying, but it's hard to tell without actually trying it…
NQNStudios commented 2025-03-01 15:44:05 +00:00 (Migrated from github.com)

What about putting the healing items for all 6 pcs in the one shop view?

Could feel weird for shops that mix healing with items. The versatility of the system is cool but tricky to design around.

What about putting the healing items for all 6 pcs in the one shop view? Could feel weird for shops that mix healing with items. The versatility of the system is cool but tricky to design around.
NQNStudios commented 2025-03-01 15:47:07 +00:00 (Migrated from github.com)

I'll do a PR we can try out the auto-switching way.

I'll do a PR we can try out the auto-switching way.
CelticMinstrel commented 2025-03-02 06:17:14 +00:00 (Migrated from github.com)

What about putting the healing items for all 6 pcs in the one shop view?

No, I don't think that works…

> What about putting the healing items for all 6 pcs in the one shop view? No, I don't think that works…
Sign in to join this conversation.
No description provided.