- boost-spirit dependency needed to be installed
- Visual Studio wanted boost/filesystem.hpp included in more places
- a deprecated enum was removed from new versions of boost, so we use
its replacement enum now
- vcpkg repository is now pinned to a commit where boost 1.84 libraries
work smoothly, there should be no more surprises
- vcpkg dependencies now cache, so successive CI runs are dramatically
faster
- for win-scons, we need to use 'call' in our batch script to source
vcvarsall.bat
- I updated the includepath and libpath we pass to win-scons to match
reality, but it still can't find any vcpkg libraries. This will need
further sleuthing
Since we can't directly use C++11 attributes, I've chosen BOOST_FALLTHROUGH to annotate intentional fallthroughs.
Thanks to @fosnola for spotting a missing break, which triggered this.
These were very shoddily put together!
It seems the person who made them never really tried building
the editors or the tests.
Also included here are a couple of minor source changes that are needed
to make the project files build.
I've checked and found that none of the existing warnings are incorrect (other than those fixed a couple commits ago), but the main reason for disabling it is that one of the warnings is in Boost.Array which I can't do a lot about.
This now requires Boost to be installed by MacPorts. However, we could add the standard Homebrew path to the include path as well to support both.
This also requires SFML and its dependencies to be installed in /Library/Frameworks; it's unclear whether this is reasonable.
Code signing is completely disabled, and Zlib is now loaded as a tbd instead of a dylib. This will probably break for some older computers, but hopefully they can just use the Xcode 4 project instead.
Boost is forcing -mt suffixes on all its libraries. Whatever. We'll just roll with that.
This makes the script work both with and without the suffixes.
Using parentheses instead of braces silences the stupid narrowing warning, so yay.
Some of these warnings are probably not correct but I can fix them later
The code signing recommendations and the suggested plist updates were skipped.
The plist changes in particular appear to be unsupported in Xcode 4.
This includes the following related or incidental changes:
* Remove the win_from_rects global variable. With one minor exception, they were all equal to the relevant render texture's size anyway.
* Split out time advancement from the handle_action function into a separate function
* Split out each individual button action into its own function
* Thanks to the above two, button actions triggered from the keyboard (and menu spells) no longer pass thru handle_action
* Side-effect: keyboard shortcuts and menu spells no longer trigger the button press animation
* Button presses now behave like proper buttons
* Button clicks are now grouped by effect in the handling code, rather than by index
* Removed a variable that mysteriously caused dialogue to become blank
