openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

bounds check when importing legacy journal entry

Browse Source
This commit is contained in:
Nat Quayle Nelson
2025-08-02 15:50:43 -05:00
parent 15eeda344b
commit b5b1d3fb1a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/universe/party.cpp
View File

@@ -283,7 +283,10 @@ void cParty::import_legacy(legacy::setup_save_type& old){
}
void cParty::cConvers::import_legacy(legacy::talk_save_type old, const cScenario& scenario){
who_said = scenario.towns[old.personality / 10]->talking.people[old.personality % 10].title;
size_t town = old.personality / 10;
size_t npc = old.personality % 10;
if(town >= scenario.towns.size()) return;
who_said = scenario.towns[town]->talking.people[npc].title;
in_town = scenario.towns[old.town_num]->name;
int strnums[2] = {old.str1, old.str2};
std::string* strs[2] = {&the_str1, &the_str2};