kiss-lang/lime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename web-worker → allow-web-workers for clarity.

Browse Source 
The former was unclear about how the dependency would relate to web workers. Would it only be available to workers? Would it automatically spin up a worker?

`allow-web-workers` isn't 100% perfect, but it implies the correct answers to the questions above (no and no) and isn't too long.
This commit is contained in:
Joseph Cloutier
2024-06-15 22:13:05 -04:00
parent 7019abb9fc
commit 593f4fa52c
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include.xml
View File

@@ -91,7 +91,7 @@
<dependency name="extension-api" path="dependencies/extension-api" if="android" />
<dependency path="dependencies/howler.min.js" if="html5 howlerjs" embed="true" />
<dependency path="dependencies/pako.min.js" if="html5" embed="true" web-worker="true" />
<dependency path="dependencies/pako.min.js" if="html5" embed="true" allow-web-workers="true" />
<dependency path="dependencies/lzma_worker-min.js" if="html5" embed="true" />
<dependency path="dependencies/FileSaver.min.js" if="html5" embed="true" />
<dependency path="dependencies/webgl-debug.js" if="html5 webgl-debug" embed="true" />

2
src/lime/tools/Dependency.hx
View File

@@ -5,7 +5,7 @@ class Dependency
// TODO: Is "forceLoad" the best name? Implement "whole-archive" on GCC
public var embed:Bool;
public var forceLoad:Bool;
public var webWorker:Bool;
public var allowWebWorkers:Bool;
public var name:String;
public var path:String;

4
src/lime/tools/ProjectXMLParser.hx
View File

@@ -1662,9 +1662,9 @@ class ProjectXMLParser extends HXProject
dependency.forceLoad = parseBool(element.att.resolve("force-load"));
}
if (element.has.resolve("web-worker"))
if (element.has.resolve("allow-web-workers"))
{
dependency.webWorker = parseBool(element.att.resolve("web-worker"));
dependency.allowWebWorkers = parseBool(element.att.resolve("allow-web-workers"));
}
var i = dependencies.length;

2
tools/platforms/HTML5Platform.hx
View File

@@ -159,7 +159,7 @@ class HTML5Platform extends PlatformTarget
if (dependency.embed && StringTools.endsWith(dependency.path, ".js") && FileSystem.exists(dependency.path))
{
var script = File.getContent(dependency.path);
if (!dependency.webWorker)
if (!dependency.allowWebWorkers)
{
script = 'if(typeof self === "undefined" || !self.constructor.name.includes("Worker")) { $script }';
}