Import town dialog says the town must be the same size as the current town #760

New Issue

2025-06-14T14:40:33Z

NQNStudios commented

2025-06-14 14:40:33 +00:00

(Migrated from github.com)

select-import-town says:

Also, the town you select must be the same size (large/medium/small) as the town currently in memory.

But the code doesn't actually check if this is true. I can only think of 1 reason why it might need to be true: if the view center on the current town will be out-of-bounds when a smaller town is imported.

I think view center should be clamped after an import, and this text should be axed from the import dialog (and manual/documentation, if it appears there).

select-import-town says: > Also, the town you select must be the same size (large/medium/small) as the town currently in memory. But the code doesn't actually check if this is true. I can only think of 1 reason why it might need to be true: if the view center on the current town will be out-of-bounds when a smaller town is imported. I think view center should be clamped after an import, and this text should be axed from the import dialog (and manual/documentation, if it appears there).

NQNStudios commented

2025-06-14 15:02:29 +00:00

(Migrated from github.com)

Ah, the documentation in fact contradicts what the dialog says:

The town selected doesn't need to be of the same size (small, medium, large) as the current town.

Ah, the documentation in fact contradicts what the dialog says: > The town selected doesn't need to be of the same size (small, medium, large) as the current town.

CelticMinstrel commented

2025-06-18 18:24:47 +00:00

(Migrated from github.com)

I think this was just a case of forgetting to update the text in the dialog when I removed the restriction.

(The restriction probably existed in old BoE due to the fact that it did not load the scenario into memory, so importing a town basically meant copying a chunk of binary data from one file to the other. Obviously, if those chunks were not the same size, that would fail catastrophically.)

By the way, it seems to me that the Question tag maybe no longer applies? I'm not sure though.

I think this was just a case of forgetting to update the text in the dialog when I removed the restriction. (The restriction probably existed in old BoE due to the fact that it did not load the scenario into memory, so importing a town basically meant copying a chunk of binary data from one file to the other. Obviously, if those chunks were not the same size, that would fail catastrophically.) By the way, it seems to me that the Question tag maybe no longer applies? I'm not sure though.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#760