Unidentified bolts don't show charges #718

New Issue

2025-04-09T15:12:51Z

NQNStudios commented

2025-04-09 15:12:51 +00:00

(Migrated from github.com)

I'm guessing that charges are intentionally not shown for unidentified magical objects, which makes sense (unless it's a scroll, but I just checked and Scroll of Flame doesn't stack so I'm extrapolating that no scrolls do).

This behavior doesn't make sense for ammunition, though. Unidentified bolts should show their charge number because it's a plainly visible quantity, not a mysterious attribute.

Hopefully this can be fixed without having to add any XML flags. Maybe the presence of the missile-type flag is enough to distinguish an item that should hide charges and one that shouldn't?

I'm guessing that charges are intentionally not shown for unidentified magical objects, which makes sense (unless it's a scroll, but I just checked and Scroll of Flame doesn't stack so I'm extrapolating that no scrolls do). This behavior doesn't make sense for ammunition, though. Unidentified bolts should show their charge number because it's a plainly visible quantity, not a mysterious attribute. Hopefully this can be fixed without having to add any XML flags. Maybe the presence of the missile-type flag is enough to distinguish an item that should hide charges and one that shouldn't?

NQNStudios commented

2025-04-09 15:35:52 +00:00

(Migrated from github.com)

Ok, here's where it happens: 7339abee84/src/game/boe.text.cpp (L329)

Due to the existence of infinite-ammo missiles like the Sling, there is more complexity here than just checking if a missile-type is present. Maybe missile != 0 && max_charges != 0 would do the trick.

Ok, here's where it happens: https://github.com/NQNStudios/cboe/blob/7339abee84c125051896eceb933e47aec203a1c3/src/game/boe.text.cpp#L329 Due to the existence of infinite-ammo missiles like the Sling, there is more complexity here than just checking if a missile-type is present. Maybe `missile != 0 && max_charges != 0` would do the trick.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#718