openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

mode integers should be enums/enum classes #699

New Issue
Open
opened 2025-03-19 14:46:23 +00:00 by NQNStudios · 1 comment
NQNStudios commented 2025-03-19 14:46:23 +00:00 (Migrated from github.com)
Copy Link

My pet peeve in the code base is how magic integers are used to specify the 'mode' of different functions. When you're reading the code, you have no idea what passing a 1 or a 0 to a function actually means. They should be enum values describing what the modes are.

My pet peeve in the code base is how magic integers are used to specify the 'mode' of different functions. When you're reading the code, you have no idea what passing a 1 or a 0 to a function actually means. They should be enum values describing what the modes are.
NQNStudios commented 2025-03-19 18:16:10 +00:00 (Migrated from github.com)
Copy Link

079021c shows an example of how I want to refactor these for readability.

[079021c](https://github.com/calref/cboe/pull/697/commits/079021c41dafda79b3d4cd81b91aba156b9ad1f5) shows an example of how I want to refactor these for readability.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
enhancement
minor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#699
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?