openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Read/write code for timers doesn't match #621

New Issue
Closed
opened 2025-02-17 14:02:56 +00:00 by CelticMinstrel · 2 comments
CelticMinstrel commented 2025-02-17 14:02:56 +00:00 (Migrated from github.com)
Copy Link

On write it outputs 3 numbers but on read it expects 4 numbers.

On write it outputs 3 numbers but on read it expects 4 numbers.
NQNStudios commented 2025-02-17 15:08:33 +00:00 (Migrated from github.com)
Copy Link

It seems like this would either cause data loss or a crash. Have you seen the bug manifest? Should it be a priority?

It seems like this would either cause data loss or a crash. Have you seen the bug manifest? Should it be a priority?
CelticMinstrel commented 2025-02-17 15:26:12 +00:00 (Migrated from github.com)
Copy Link

I noticed it while reviewing #346, which has a fix for it that can't be cherry-picked due to my tag-file rework. I haven't seen it manifest in actual practice.

It makes sense to prioritize it, since it would indeed lead to timers being lost or corrupted when loading a saved game.

I noticed it while reviewing #346, which has a fix for it that can't be cherry-picked due to my tag-file rework. I haven't seen it manifest in actual practice. It makes sense to prioritize it, since it would indeed lead to timers being lost or corrupted when loading a saved game.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
bug
core
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#621
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?