Showpipes option shouldn't be exposed in XML #609

New Issue

2025-02-15T16:04:36Z

CelticMinstrel commented

2025-02-15 16:04:36 +00:00

(Migrated from github.com)

I realized recently that there's no reason to expose the showpipes option to the XML schema. It's needed in the text render function, but the XML schema has the <br/> element for adding line breaks. So, setting showpipes could just be automatically set if a pipe is found while parsing the XML.

All the places where we actually want to consider pipes involve setting the text dynamically at runtime, so in that case showpipes wouldn't be set – it would have to be set separately at runtime if the caller wants them shown.

I realized recently that there's no reason to expose the `showpipes` option to the XML schema. It's needed in the text render function, but the XML schema has the `<br/>` element for adding line breaks. So, setting `showpipes` could just be automatically set if a pipe is found while parsing the XML. All the places where we _actually_ want to consider pipes involve setting the text dynamically at runtime, so in that case `showpipes` wouldn't be set – it would have to be set separately at runtime if the caller wants them shown.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#609