openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix text size and underline in dialogxml #592

Merged
NQNStudios merged 9 commits from fix-246 into master 2025-02-10 04:05:22 +00:00
Conversation 4 Commits 9 Files Changed 10 +45 -24
NQNStudios commented 2025-02-09 17:17:32 +00:00 (Migrated from github.com)
Copy Link

This should fix #246 ...

However, it does not, because for some reason, message controls are ignoring their text size. (This goes for the preset sizes that already existed, too.)

This should fix #246 ... However, it does not, because for some reason, message controls are ignoring their text size. (This goes for the preset sizes that already existed, too.)
NQNStudios commented 2025-02-09 17:18:54 +00:00 (Migrated from github.com)
Copy Link

Fixing the bug will require going back through a lot of dialogs to make sure they look good with working large text on headings.

Grepping for the preset sizes should help with that.

Fixing the bug will require going back through a lot of dialogs to make sure they look good with working large text on headings. Grepping for the preset sizes should help with that.
NQNStudios commented 2025-02-09 17:36:10 +00:00 (Migrated from github.com)
Copy Link

Checked:

$ rg -l "text size='"
pkg/credits/about-boe-template.xml
rsrc/dialogs/edit-personality.xml
rsrc/dialogs/tip-of-day.xml
rsrc/dialogs/edit-xp.xml
rsrc/dialogs/edit-sounds.xml
rsrc/dialogs/edit-special-node.xml
rsrc/dialogs/edit-save-rects.xml
rsrc/dialogs/preferences.xml
rsrc/dialogs/select-town-enter.xml
rsrc/dialogs/pref-scenario.xml
rsrc/dialogs/edit-scenario-events.xml
rsrc/dialogs/edit-intro.xml
rsrc/dialogs/pref-character.xml
rsrc/dialogs/skill-info.xml
rsrc/dialogs/about-boe.xml
rsrc/dialogs/edit-town-events.xml
rsrc/dialogs/edit-shop-item.xml
rsrc/dialogs/set-area-desc.xml
rsrc/dialogs/item-info.xml
rsrc/dialogs/pick-race-abil.xml
rsrc/dialogs/edit-monster.xml
rsrc/dialogs/pick-scenario.xml
rsrc/dialogs/edit-special-text-sm.xml
rsrc/dialogs/edit-special-assign.xml
rsrc/dialogs/graphic-sheets.xml
rsrc/dialogs/drop-item-confirm.xml
rsrc/dialogs/edit-outdoor-encounter.xml
rsrc/dialogs/edit-terrain.xml
rsrc/dialogs/quit-confirm-save.xml
rsrc/dialogs/make-scenario1.xml
rsrc/dialogs/resize-outdoors.xml
rsrc/dialogs/edit-text.xml
rsrc/dialogs/set-sdf.xml
rsrc/dialogs/edit-outdoor-details.xml
rsrc/dialogs/event-journal.xml
rsrc/dialogs/edit-quest.xml
rsrc/dialogs/edit-special-item.xml

Still need to check:

rsrc/dialogs/edit-mabil-general.xml
rsrc/dialogs/change-terrain.xml
rsrc/dialogs/help-hints.xml
rsrc/dialogs/edit-town-advanced.xml
rsrc/dialogs/monster-info.xml
rsrc/dialogs/select-import-town.xml
rsrc/dialogs/edit-scenario-details.xml
rsrc/dialogs/edit-talk-node.xml
rsrc/dialogs/talk-notes.xml
rsrc/dialogs/edit-townperson-advanced.xml
rsrc/dialogs/job-board.xml
rsrc/dialogs/soul-crystal.xml
rsrc/dialogs/edit-item.xml
rsrc/dialogs/save-revert.xml
rsrc/dialogs/save-quit.xml
rsrc/dialogs/save-close.xml
rsrc/dialogs/spend-xp.xml
rsrc/dialogs/edit-dialog-text.xml
rsrc/dialogs/edit-party.xml
rsrc/dialogs/edit-monster-abils.xml
rsrc/dialogs/make-scenario2.xml
rsrc/dialogs/edit-townperson.xml
rsrc/dialogs/edit-mabil-radiate.xml
rsrc/dialogs/edit-mabil-special.xml
rsrc/dialogs/edit-town-varying.xml
rsrc/dialogs/edit-special-text.xml
rsrc/dialogs/pick-pc-name.xml
rsrc/dialogs/pc-info.xml
rsrc/dialogs/edit-mabil-summon.xml
rsrc/dialogs/cast-spell.xml
rsrc/dialogs/save-open.xml
rsrc/dialogs/graphic-types.xml
rsrc/dialogs/edit-shop-special.xml
rsrc/dialogs/pc-alchemy-info.xml
rsrc/dialogs/edit-town-details.xml
rsrc/dialogs/select-sector.xml
rsrc/dialogs/pick-potion.xml
rsrc/dialogs/new-town.xml
rsrc/dialogs/edit-shop.xml
rsrc/dialogs/edit-mabil-missile.xml
rsrc/dialogs/edit-item-shortcut.xml
rsrc/dialogs/select-town-edit.xml
rsrc/dialogs/adventure-notes.xml
rsrc/dialogs/edit-sign.xml
rsrc/dialogs/edit-placed-item.xml
Checked: ``` $ rg -l "text size='" pkg/credits/about-boe-template.xml rsrc/dialogs/edit-personality.xml rsrc/dialogs/tip-of-day.xml rsrc/dialogs/edit-xp.xml rsrc/dialogs/edit-sounds.xml rsrc/dialogs/edit-special-node.xml rsrc/dialogs/edit-save-rects.xml rsrc/dialogs/preferences.xml rsrc/dialogs/select-town-enter.xml rsrc/dialogs/pref-scenario.xml rsrc/dialogs/edit-scenario-events.xml rsrc/dialogs/edit-intro.xml rsrc/dialogs/pref-character.xml rsrc/dialogs/skill-info.xml rsrc/dialogs/about-boe.xml rsrc/dialogs/edit-town-events.xml rsrc/dialogs/edit-shop-item.xml rsrc/dialogs/set-area-desc.xml rsrc/dialogs/item-info.xml rsrc/dialogs/pick-race-abil.xml rsrc/dialogs/edit-monster.xml rsrc/dialogs/pick-scenario.xml rsrc/dialogs/edit-special-text-sm.xml rsrc/dialogs/edit-special-assign.xml rsrc/dialogs/graphic-sheets.xml rsrc/dialogs/drop-item-confirm.xml rsrc/dialogs/edit-outdoor-encounter.xml rsrc/dialogs/edit-terrain.xml rsrc/dialogs/quit-confirm-save.xml rsrc/dialogs/make-scenario1.xml rsrc/dialogs/resize-outdoors.xml rsrc/dialogs/edit-text.xml rsrc/dialogs/set-sdf.xml rsrc/dialogs/edit-outdoor-details.xml rsrc/dialogs/event-journal.xml rsrc/dialogs/edit-quest.xml rsrc/dialogs/edit-special-item.xml ``` Still need to check: ``` rsrc/dialogs/edit-mabil-general.xml rsrc/dialogs/change-terrain.xml rsrc/dialogs/help-hints.xml rsrc/dialogs/edit-town-advanced.xml rsrc/dialogs/monster-info.xml rsrc/dialogs/select-import-town.xml rsrc/dialogs/edit-scenario-details.xml rsrc/dialogs/edit-talk-node.xml rsrc/dialogs/talk-notes.xml rsrc/dialogs/edit-townperson-advanced.xml rsrc/dialogs/job-board.xml rsrc/dialogs/soul-crystal.xml rsrc/dialogs/edit-item.xml rsrc/dialogs/save-revert.xml rsrc/dialogs/save-quit.xml rsrc/dialogs/save-close.xml rsrc/dialogs/spend-xp.xml rsrc/dialogs/edit-dialog-text.xml rsrc/dialogs/edit-party.xml rsrc/dialogs/edit-monster-abils.xml rsrc/dialogs/make-scenario2.xml rsrc/dialogs/edit-townperson.xml rsrc/dialogs/edit-mabil-radiate.xml rsrc/dialogs/edit-mabil-special.xml rsrc/dialogs/edit-town-varying.xml rsrc/dialogs/edit-special-text.xml rsrc/dialogs/pick-pc-name.xml rsrc/dialogs/pc-info.xml rsrc/dialogs/edit-mabil-summon.xml rsrc/dialogs/cast-spell.xml rsrc/dialogs/save-open.xml rsrc/dialogs/graphic-types.xml rsrc/dialogs/edit-shop-special.xml rsrc/dialogs/pc-alchemy-info.xml rsrc/dialogs/edit-town-details.xml rsrc/dialogs/select-sector.xml rsrc/dialogs/pick-potion.xml rsrc/dialogs/new-town.xml rsrc/dialogs/edit-shop.xml rsrc/dialogs/edit-mabil-missile.xml rsrc/dialogs/edit-item-shortcut.xml rsrc/dialogs/select-town-edit.xml rsrc/dialogs/adventure-notes.xml rsrc/dialogs/edit-sign.xml rsrc/dialogs/edit-placed-item.xml ```
CelticMinstrel commented 2025-02-09 22:38:14 +00:00 (Migrated from github.com)
Copy Link

What if there are some that have size not as the first attribute?

What if there are some that have size not as the first attribute?
NQNStudios commented 2025-02-09 22:47:49 +00:00 (Migrated from github.com)
Copy Link

Ahhh here's the list with a modified grep to account for that.

$ rg -l "text.*size='"
pkg/credits/about-boe-template.xml
rsrc/dialogs/edit-scenario-events.xml
rsrc/dialogs/pick-race-abil.xml
rsrc/dialogs/edit-special-assign.xml
rsrc/dialogs/edit-personality.xml
rsrc/dialogs/get-num.xml
rsrc/dialogs/edit-item-abils.xml
rsrc/dialogs/edit-shop-item.xml
rsrc/dialogs/pick-scenario.xml
rsrc/dialogs/drop-item-confirm.xml
rsrc/dialogs/edit-outdoor-details.xml
rsrc/dialogs/help-hints.xml
rsrc/dialogs/edit-town-advanced.xml
rsrc/dialogs/edit-mabil-general.xml
rsrc/dialogs/change-terrain.xml
rsrc/dialogs/tip-of-day.xml
rsrc/dialogs/event-journal.xml
rsrc/dialogs/edit-terrain.xml
rsrc/dialogs/edit-xp.xml
rsrc/dialogs/resize-outdoors.xml
rsrc/dialogs/edit-sounds.xml
rsrc/dialogs/edit-text.xml
rsrc/dialogs/edit-special-node.xml
rsrc/dialogs/pc-spell-info.xml
rsrc/dialogs/many-str.xml
rsrc/dialogs/edit-save-rects.xml
rsrc/dialogs/preferences.xml
rsrc/dialogs/set-sdf.xml
rsrc/dialogs/edit-quest.xml
rsrc/dialogs/set-area-desc.xml
rsrc/dialogs/edit-monster.xml
rsrc/dialogs/select-town-enter.xml
rsrc/dialogs/graphic-sheets.xml
rsrc/dialogs/skill-info.xml
rsrc/dialogs/pref-character.xml
rsrc/dialogs/edit-outdoor-encounter.xml
rsrc/dialogs/edit-item.xml
rsrc/dialogs/save-quit.xml
rsrc/dialogs/about-boe.xml
rsrc/dialogs/edit-dialog-text.xml
rsrc/dialogs/make-scenario1.xml
rsrc/dialogs/edit-special-item.xml
rsrc/dialogs/edit-mabil-special.xml
rsrc/dialogs/item-info.xml
rsrc/dialogs/edit-scenario-details.xml
rsrc/dialogs/edit-town-varying.xml
rsrc/dialogs/save-revert.xml
rsrc/dialogs/choose-pict.xml
rsrc/dialogs/select-import-town.xml
rsrc/dialogs/spend-xp.xml
rsrc/dialogs/save-close.xml
rsrc/dialogs/edit-talk-node.xml
rsrc/dialogs/make-scenario2.xml
rsrc/dialogs/edit-mabil-summon.xml
rsrc/dialogs/edit-townperson-advanced.xml
rsrc/dialogs/get-response.xml
rsrc/dialogs/get-items.xml
rsrc/dialogs/job-board.xml
rsrc/dialogs/monster-info.xml
rsrc/dialogs/edit-vehicle.xml
rsrc/dialogs/choose-bg.xml
rsrc/dialogs/edit-shop.xml
rsrc/dialogs/edit-town-details.xml
rsrc/dialogs/pick-potion.xml
rsrc/dialogs/edit-mabil-missile.xml
rsrc/dialogs/pick-pc-name.xml
rsrc/dialogs/edit-shop-special.xml
rsrc/dialogs/edit-sign.xml
rsrc/dialogs/select-pc.xml
rsrc/dialogs/edit-special-text.xml
rsrc/dialogs/cast-spell.xml
rsrc/dialogs/adventure-notes.xml
rsrc/dialogs/pc-info.xml
rsrc/dialogs/graphic-types.xml
rsrc/dialogs/choose-string.xml
rsrc/dialogs/pref-scenario.xml
rsrc/dialogs/edit-intro.xml
rsrc/dialogs/talk-notes.xml
rsrc/dialogs/edit-town-events.xml
rsrc/dialogs/soul-crystal.xml
rsrc/dialogs/edit-monster-abils.xml
rsrc/dialogs/edit-townperson.xml
rsrc/dialogs/edit-party.xml
rsrc/dialogs/edit-special-text-sm.xml
rsrc/dialogs/edit-mabil-radiate.xml
rsrc/dialogs/show-map.xml
rsrc/dialogs/quit-confirm-save.xml
rsrc/dialogs/select-town-edit.xml
rsrc/dialogs/select-sector.xml
rsrc/dialogs/pc-alchemy-info.xml
rsrc/dialogs/new-town.xml
rsrc/dialogs/save-open.xml
rsrc/dialogs/edit-day.xml
rsrc/dialogs/edit-placed-item.xml
rsrc/dialogs/edit-item-shortcut.xml

I'll have to re-sort out the ones I've checked based on the first grep.

Ahhh here's the list with a modified grep to account for that. ``` $ rg -l "text.*size='" pkg/credits/about-boe-template.xml rsrc/dialogs/edit-scenario-events.xml rsrc/dialogs/pick-race-abil.xml rsrc/dialogs/edit-special-assign.xml rsrc/dialogs/edit-personality.xml rsrc/dialogs/get-num.xml rsrc/dialogs/edit-item-abils.xml rsrc/dialogs/edit-shop-item.xml rsrc/dialogs/pick-scenario.xml rsrc/dialogs/drop-item-confirm.xml rsrc/dialogs/edit-outdoor-details.xml rsrc/dialogs/help-hints.xml rsrc/dialogs/edit-town-advanced.xml rsrc/dialogs/edit-mabil-general.xml rsrc/dialogs/change-terrain.xml rsrc/dialogs/tip-of-day.xml rsrc/dialogs/event-journal.xml rsrc/dialogs/edit-terrain.xml rsrc/dialogs/edit-xp.xml rsrc/dialogs/resize-outdoors.xml rsrc/dialogs/edit-sounds.xml rsrc/dialogs/edit-text.xml rsrc/dialogs/edit-special-node.xml rsrc/dialogs/pc-spell-info.xml rsrc/dialogs/many-str.xml rsrc/dialogs/edit-save-rects.xml rsrc/dialogs/preferences.xml rsrc/dialogs/set-sdf.xml rsrc/dialogs/edit-quest.xml rsrc/dialogs/set-area-desc.xml rsrc/dialogs/edit-monster.xml rsrc/dialogs/select-town-enter.xml rsrc/dialogs/graphic-sheets.xml rsrc/dialogs/skill-info.xml rsrc/dialogs/pref-character.xml rsrc/dialogs/edit-outdoor-encounter.xml rsrc/dialogs/edit-item.xml rsrc/dialogs/save-quit.xml rsrc/dialogs/about-boe.xml rsrc/dialogs/edit-dialog-text.xml rsrc/dialogs/make-scenario1.xml rsrc/dialogs/edit-special-item.xml rsrc/dialogs/edit-mabil-special.xml rsrc/dialogs/item-info.xml rsrc/dialogs/edit-scenario-details.xml rsrc/dialogs/edit-town-varying.xml rsrc/dialogs/save-revert.xml rsrc/dialogs/choose-pict.xml rsrc/dialogs/select-import-town.xml rsrc/dialogs/spend-xp.xml rsrc/dialogs/save-close.xml rsrc/dialogs/edit-talk-node.xml rsrc/dialogs/make-scenario2.xml rsrc/dialogs/edit-mabil-summon.xml rsrc/dialogs/edit-townperson-advanced.xml rsrc/dialogs/get-response.xml rsrc/dialogs/get-items.xml rsrc/dialogs/job-board.xml rsrc/dialogs/monster-info.xml rsrc/dialogs/edit-vehicle.xml rsrc/dialogs/choose-bg.xml rsrc/dialogs/edit-shop.xml rsrc/dialogs/edit-town-details.xml rsrc/dialogs/pick-potion.xml rsrc/dialogs/edit-mabil-missile.xml rsrc/dialogs/pick-pc-name.xml rsrc/dialogs/edit-shop-special.xml rsrc/dialogs/edit-sign.xml rsrc/dialogs/select-pc.xml rsrc/dialogs/edit-special-text.xml rsrc/dialogs/cast-spell.xml rsrc/dialogs/adventure-notes.xml rsrc/dialogs/pc-info.xml rsrc/dialogs/graphic-types.xml rsrc/dialogs/choose-string.xml rsrc/dialogs/pref-scenario.xml rsrc/dialogs/edit-intro.xml rsrc/dialogs/talk-notes.xml rsrc/dialogs/edit-town-events.xml rsrc/dialogs/soul-crystal.xml rsrc/dialogs/edit-monster-abils.xml rsrc/dialogs/edit-townperson.xml rsrc/dialogs/edit-party.xml rsrc/dialogs/edit-special-text-sm.xml rsrc/dialogs/edit-mabil-radiate.xml rsrc/dialogs/show-map.xml rsrc/dialogs/quit-confirm-save.xml rsrc/dialogs/select-town-edit.xml rsrc/dialogs/select-sector.xml rsrc/dialogs/pc-alchemy-info.xml rsrc/dialogs/new-town.xml rsrc/dialogs/save-open.xml rsrc/dialogs/edit-day.xml rsrc/dialogs/edit-placed-item.xml rsrc/dialogs/edit-item-shortcut.xml ``` I'll have to re-sort out the ones I've checked based on the first grep.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#592
No description provided.
Delete Branch "fix-246"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?