Scrollbars persist after game over #558

New Issue

2025-01-31T12:32:45Z

josefwk commented

2025-01-31 12:32:45 +00:00

(Migrated from github.com)

OS: Ubuntu 24.04.1 LTS
Commit: 2ec456b
Issue: Scrollbars remain on-screen after returning to the main menu from a game over event. This only persists when choosing to Restore a saved game that is not in a scenario.
How to reproduce: Load a party, start a scenario, then kill all PCs (either through damage or by choosing Delete PC). Once the game over dialog appears, select Restore and load a party that is not in a scenario.
Additional notes: This does not seem to happen when returning from a scenario to the main menu by choosing Abort, New Game, or Open Game from the menu. Choosing Restart from the game over dialog seems to eventually (after saving or cancelling the new party) cause a redraw/removal of the scrollbars as well.

**OS:** Ubuntu 24.04.1 LTS **Commit:** `2ec456b` **Issue:** Scrollbars remain on-screen after returning to the main menu from a game over event. This only persists when choosing to Restore a saved game that is not in a scenario. **How to reproduce:** Load a party, start a scenario, then kill all PCs (either through damage or by choosing Delete PC). Once the game over dialog appears, select Restore and load a party that is not in a scenario. **Additional notes:** This does not seem to happen when returning from a scenario to the main menu by choosing Abort, New Game, or Open Game from the menu. Choosing Restart from the game over dialog seems to eventually (after saving or cancelling the new party) cause a redraw/removal of the scrollbars as well. ![Image](https://github.com/user-attachments/assets/06ccdafe-5e8f-4fb5-a57a-48d92c1845a4)

NQNStudios commented

2025-01-31 14:07:29 +00:00

(Migrated from github.com)

Thank you for these detailed bug reports! I think this one happens to be a duplicate of #250 but the additional info you provided might help us solve it.

josefwk commented

2025-01-31 14:14:53 +00:00

(Migrated from github.com)

Thanks. Just tested a local change and it seems to have solved the issue. I haven't tested it on other builds for other operating systems though, so not sure it's worthy of a PR at this point. But if you want to test it out, in boe.actions.cpp and within the handle_death() function, just call reload_startup() before the while loop (and remove the call from the condition within the loop).

The reason for this edit was twofold: first, when the death dialog box appears, the scrollbars are visible on the main menu when they shouldn't be, so it already seemed like a good place to hide those UI elements. But also in the condition where the player selects "load", it is possible that reload_startup() is not called at all.

Thanks. Just tested a local change and it seems to have solved the issue. I haven't tested it on other builds for other operating systems though, so not sure it's worthy of a PR at this point. But if you want to test it out, in `boe.actions.cpp` and within the `handle_death()` function, just call `reload_startup()` before the while loop (and remove the call from the condition within the loop). The reason for this edit was twofold: first, when the death dialog box appears, the scrollbars are visible on the main menu when they shouldn't be, so it already seemed like a good place to hide those UI elements. But also in the condition where the player selects "load", it is possible that `reload_startup()` is not called at all.

NQNStudios commented

2025-01-31 16:21:50 +00:00

(Migrated from github.com)

If you fixed it on your end I'd say that's worth a PR for sure (we'll make sure to review the fix and test it on the other platforms). You can add your name to pkg/credits/Code.txt as well to be credited in the game.

(the generate-credits script will need to be run after modifying the text file. it has a couple dependencies so I can always be the one to do that.)

If you fixed it on your end I'd say that's worth a PR for sure (we'll make sure to review the fix and test it on the other platforms). You can add your name to pkg/credits/Code.txt as well to be credited in the game. (the generate-credits script will need to be run after modifying the text file. it has a couple dependencies so I can always be the one to do that.)

josefwk commented

2025-02-01 21:24:12 +00:00

(Migrated from github.com)

Submitted PR #560 to hopefully resolve this issue.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#558