Fix multiple inconsistencies when saving #550

2025-01-25T22:55:03Z

NQNStudios commented

2025-01-25 22:55:03 +00:00

(Migrated from github.com)

I discovered #549 while debugging the rest of these issues, so I fixed it first.

I made debug_leave_town() call end_town_mode() so it does everything that would normally be done when going outdoors, minus handling exit special nodes. That was the fix. (Fix #549)

Issues #204, #267, and #480 were all caused by having duplicated save game logic in many places, which were not all the same. I refactored things so every time you Save or Save As, it follows the same code-path and does everything that it should no matter the context that triggered it.

Fix #204
Fix #267
Fix #480

EDIT: Ah, of course this is gonna break the PC editor, I need to fix that.

I discovered #549 while debugging the rest of these issues, so I fixed it first. I made `debug_leave_town()` call `end_town_mode()` so it does everything that would normally be done when going outdoors, minus handling exit special nodes. That was the fix. (Fix #549) Issues #204, #267, and #480 were all caused by having duplicated save game logic in many places, which were not all the same. I refactored things so every time you Save or Save As, it follows the same code-path and does everything that it should no matter the context that triggered it. Fix #204 Fix #267 Fix #480 EDIT: Ah, of course this is gonna break the PC editor, I need to fix that.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#550