Replays from older builds click the wrong startup button #533

New Issue

2025-01-15T15:34:57Z

NQNStudios commented

2025-01-15 15:34:57 +00:00

(Migrated from github.com)

https://github.com/calref/cboe/pull/500 rearranged and combined startup menu buttons.

Replays from builds prior to https://github.com/calref/cboe/pull/500 still encode startup button indices according to the old layout, so they don't work in newer builds if they click a startup button that moved.

This could be hairy to implement a real fix for -- (How can you programmatically determine if the build comes after a specific commit SHA?). Another solution I'd be okay with, is just directly editing the indices in all the logs we have in test/replays. (And then we promise not to rearrange buttons again.)

https://github.com/calref/cboe/pull/500 rearranged and combined startup menu buttons. Replays from builds prior to https://github.com/calref/cboe/pull/500 still encode startup button indices according to the old layout, so they don't work in newer builds if they click a startup button that moved. This could be hairy to implement a real fix for -- (How can you programmatically determine if the build comes after a specific commit SHA?). Another solution I'd be okay with, is just directly editing the indices in all the logs we have in `test/replays`. (And then we promise not to rearrange buttons again.)

CelticMinstrel commented

2025-01-16 03:45:15 +00:00

(Migrated from github.com)

We could encode startup buttons as a name instead of an index. Then rearranging them wouldn't cause any issues. In the event of removing a button, the replay would have to give an error message of some kind, unless we include backwards compatibility for that removed button.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#533