openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix some repetitive code in dialogs #376

Merged
NQNStudios merged 2 commits from dry-dialog into master 2024-07-06 04:06:03 +00:00
Conversation 2 Commits 2 Files Changed 3 +57 -82
NQNStudios commented 2024-07-04 01:34:27 +00:00 (Migrated from github.com)
Copy Link

I saw a couple of repetitive things in cControl and cDialog, one of which was marked with a TODO to deduplicate it.

In the first case, I simply made a function and changed the 2 repetitive places to call the function.

The second case was more complicated, and my change actually does change the behavior, but I don't think it should matter unless any widgets have containers in containers and we want those not to be processed recursively (how it was before).

I saw a couple of repetitive things in cControl and cDialog, one of which was marked with a TODO to deduplicate it. In the first case, I simply made a function and changed the 2 repetitive places to call the function. The second case was more complicated, and my change actually does change the behavior, but I don't think it should matter unless any widgets have containers in containers and we want those *not* to be processed recursively (how it was before).
CelticMinstrel commented 2024-07-05 03:53:07 +00:00 (Migrated from github.com)
Copy Link

Took me a while to work out what the change was that you made in the second commit, but now that I've worked it out, it seems fine to me.

This is out of scope for this PR, probably, but the first commit makes me realize that it might make sense for cControl to have a member variable that specifies the click sound. Dynamic casting to cLed as a special case is such a hack.

Took me a while to work out what the change was that you made in the second commit, but now that I've worked it out, it seems fine to me. This is out of scope for this PR, probably, but the first commit makes me realize that it might make sense for cControl to have a member variable that specifies the click sound. Dynamic casting to `cLed` as a special case is such a hack.
NQNStudios commented 2024-07-05 18:44:23 +00:00 (Migrated from github.com)
Copy Link

The CI failure for win-vs64 looks like an intermittent unit test failure that happens sometimes.

The CI failure for win-vs64 looks like an intermittent unit test failure that happens sometimes.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#376
No description provided.
Delete Branch "dry-dialog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?