Fix fullscreen window sizing on MacOS HighDPI display #370

2024-06-20T02:38:19Z

NQNStudios commented

2024-06-20 02:38:19 +00:00

(Migrated from github.com)

Fixes #369 in a counterintuitive way.

I would have thought that we would want the flag that says High DPI displays are supported (which was even something Fosnola had done and I tried cherry-picking to fix this.)

But this very old SFML forum thread suggested setting the very same flag to false. Which I did, and it fixed both parts of the issue--the fullscreen window size, and the positioning of dialog windows.

Fixes #369 in a counterintuitive way. I would have thought that we would want the flag that says High DPI displays *are* supported (which was even something [Fosnola](https://github.com/calref/cboe/pull/346/commits/ff05298ebec161cded8b8aa0821b4879bd0b9954) had done and I tried cherry-picking to fix this.) But this [very old SFML forum thread](https://en.sfml-dev.org/forums/index.php?topic=17241.msg124542#msg124542) suggested setting the very same flag to false. Which I did, and it fixed both parts of the issue--the fullscreen window size, and the positioning of dialog windows.

CelticMinstrel commented

2024-06-23 05:53:15 +00:00

(Migrated from github.com)

I think this probably is correct. After all, OBoE is indeed not conscious of hi-DPI displays, requiring the user to intervene manually to apply a scaling factor.

I think this probably _is_ correct. After all, OBoE is indeed not conscious of hi-DPI displays, requiring the user to intervene manually to apply a scaling factor.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#370