Local build improvement redo #357

2024-05-31T02:18:44Z

NQNStudios commented

2024-05-31 02:18:44 +00:00

(Migrated from github.com)

This is the last PR, with submodules instead of subtrees, and a few more things:

add Catch2 dependency to the README
partial build options
correct debug flags on all platforms
when scons -c is called, print a note about deleting .sconsign.dblite (this addresses #330, which I still can't reliably fix, but deleting the file manually works every time)

This is the last PR, with submodules instead of subtrees, and a few more things: * add Catch2 dependency to the README * partial build options * correct debug flags on all platforms * when scons -c is called, print a note about deleting .sconsign.dblite (this addresses #330, which I still can't reliably fix, but deleting the file manually works every time)

🎉 1 🚀 1

CelticMinstrel (Migrated from github.com) reviewed 2024-05-31 02:30:48 +00:00

SConstruct

						
				@@ -221,12 +248,15 @@ if platform == 'darwin':

				# Sometimes it's easier just to copy the dependencies into the repo dir

CelticMinstrel (Migrated from github.com) commented

2024-05-31 02:30:48 +00:00

I'm not really a fan of concatenating os.getcwd() like this. I'd prefer to use a dedicated path join function (either os.path or pathlib).

I'm not really a fan of concatenating `os.getcwd()` like this. I'd prefer to use a dedicated path join function (either `os.path` or `pathlib`).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#357

				`@@ -221,12 +248,15 @@ if platform == 'darwin':`
				`# Sometimes it's easier just to copy the dependencies into the repo dir`