openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Terrain changes are not reflected in the lighting array #32

New Issue
Closed
opened 2013-06-21 00:26:19 +00:00 by sylae · 4 comments
sylae commented 2013-06-21 00:26:19 +00:00 (Migrated from github.com)
Copy Link

Terrain changes (such as through a Change Terrain node) do not update the t_d.lighting array.

It's been pointed out that this aspect of the bug could be useful, and as such I'm going to modify the Change Town Lighting node to allow this feature (so that you can "purge" the lighting array by setting it to the same light level it already was).

Terrain changes (such as through a Change Terrain node) do not update the t_d.lighting array. It's been pointed out that this aspect of the bug could be useful, and as such I'm going to modify the Change Town Lighting node to allow this feature (so that you can "purge" the lighting array by setting it to the same light level it already was).
sylae commented 2013-06-21 00:39:25 +00:00 (Migrated from github.com)
Copy Link

commit d289ae8 partially fixes this issue by copy-pasting the lighting generation code from the Scenario Editor. However, due to unknown circumstances, any "warped in" light-emitting tiles (i.e. change a cave floor to a torch" will only emit a radius of one tile. I'm not quite sure how to fix this.

commit d289ae8 partially fixes this issue by copy-pasting the lighting generation code from the Scenario Editor. However, due to unknown circumstances, any "warped in" light-emitting tiles (i.e. change a cave floor to a torch" will only emit a radius of one tile. I'm not quite sure how to fix this.
CelticMinstrel commented 2015-06-14 05:58:16 +00:00 (Migrated from github.com)
Copy Link

I haven't tested yet to be sure it works right, but lighting is now recalculated whenever a terrain space is changed to a type with a different light radius. I'm wondering what about the bug could be useful though?

I haven't tested yet to be sure it works right, but lighting is now recalculated whenever a terrain space is changed to a type with a different light radius. I'm wondering what about the bug could be useful though?
CelticMinstrel commented 2018-02-11 17:29:27 +00:00 (Migrated from github.com)
Copy Link

Pretty sure I fixed this by always regenerating the lighting after a terrain change...

Pretty sure I fixed this by always regenerating the lighting after a terrain change...
NQNStudios commented 2025-02-06 14:32:24 +00:00 (Migrated from github.com)
Copy Link

Confirmed: this is fixed.

Confirmed: this is fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
bug
game
Milestone
No items
No Milestone 2.0
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#32
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?