openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix debug mode (and other universe flags) being randomly set on upon load #261

Merged
x-qq merged 1 commits from fix_debug_mode_randomly_on into master 2020-02-11 13:57:41 +00:00
Conversation 1 Commits 1 Files Changed 1 +3 -1
x-qq commented 2020-02-11 13:38:41 +00:00 (Migrated from github.com)
Copy Link

Upon loading a save, a new instance of universe is default-constructed and then moved into existing universe. The problem is that several boolean flags in universe do not have initializers, so they sometimes end up with garbage values.

Fixes #198
Fixes #200

Upon loading a save, a new instance of universe is default-constructed and then moved into existing universe. The problem is that several boolean flags in universe do not have initializers, so they sometimes end up with garbage values. Fixes #198 Fixes #200
CelticMinstrel commented 2020-02-11 13:52:56 +00:00 (Migrated from github.com)
Copy Link

I would've used = initializers but whatever, it doesn't matter. Merging.

I would've used = initializers but whatever, it doesn't matter. Merging.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#261
No description provided.
Delete Branch "fix_debug_mode_randomly_on"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?