openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix unclickable shop info icons #260

Merged
x-qq merged 2 commits from fix_shop_icons_not_clickable into master 2020-02-11 13:57:42 +00:00
Conversation 1 Commits 2 Files Changed 4 +33 -16
x-qq commented 2020-02-11 09:41:49 +00:00 (Migrated from github.com)
Copy Link
  • Fixed unclickable shop icons by applying the same offset to event catching rects as is applied to the shop UI when it's being drawn in the main window.
  • Removed strange adjustment of mouse click coords in shop UI by (-5, -5) px.
  • Removed click_shop_rect function that was doing "click emulation" in shop UI. Rationale: 1) it was causing visual glitches, because 2) various widgets do not get to decide when .display() is called, since other drawables may not be ready
  • Removed unneeded shop scrollbar redraw call which may improve performance of that UI a bit

Fixes #247

* Fixed unclickable shop icons by applying the same offset to event catching rects as is applied to the shop UI when it's being drawn in the main window. * Removed strange adjustment of mouse click coords in shop UI by (-5, -5) px. * Removed click_shop_rect function that was doing "click emulation" in shop UI. Rationale: 1) it was causing visual glitches, because 2) various widgets do not get to decide when .display() is called, since other drawables may not be ready * Removed unneeded shop scrollbar redraw call which may improve performance of that UI a bit Fixes #247
CelticMinstrel commented 2020-02-11 13:20:14 +00:00 (Migrated from github.com)
Copy Link

You've removed click_shop_rect for some reason and now draw_shop_graphics is neverr called with true, which if I understand correctly means the pressed effect when clicking will not occur. Can you fix this, please? Putting click_shop_rect back where it was would be the easiest way, but whatever way you prefer is fine too.

You've removed `click_shop_rect` for some reason and now `draw_shop_graphics` is neverr called with `true`, which if I understand correctly means the pressed effect when clicking will not occur. Can you fix this, please? Putting `click_shop_rect` back where it was would be the easiest way, but whatever way you prefer is fine too.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ASR
Specific to the A Small Rebellion scenario
BB
Specific to the Bandit Busywork scenario
bug
charedit
Affects the character editor
core
Affects core systems other than dialogs
dialogxml
Affects the dialog system
duplicate
enhancement
game
Affects the game, as opposed to the editors
important
A high priority task
invalid
linux
Specific to Linux builds
mac
Specific to Mac builds
meta
Related to the build system or other things other than the code
minor
A low priority task
Needs more info
question
replay
Affects the replay system
resources
Specific to the game's assets and resources
scenedit
Affects the scenario editor
Tutorial
Specific to the Tutorial scenario
unconfirmed
VoDT
Specific to the Valley of Dying Things scenario
windows
Specific to Windows builds
wontfix
work
Non coding related task
ZKR
Specific to the Za-Khazi Run scenario
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CelticMinstrel NQN
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openboe/oboe#260
No description provided.
Delete Branch "fix_shop_icons_not_clickable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?