Adding vs2017 project in new proj directory parallel to src #176

2018-02-25T20:04:59Z

daerogami commented

2018-02-25 20:04:59 +00:00

(Migrated from github.com)

Tests and Install project are still WIP but shouldn't be a hold up to getting this merged.
I will move the vs2013 proj in another PR.
I am holding off on tests because I will work on MSTEST integration for both vs2013 and vs2017 in a different PR.
Install project in vs2017 is not a priority because as long as it still works in vs2013, @CelticMinstrel's workflow for creating releases will remain unaffected.

Tests and Install project are still WIP but shouldn't be a hold up to getting this merged. I will move the vs2013 proj in another PR. I am holding off on tests because I will work on MSTEST integration for both vs2013 and vs2017 in a different PR. Install project in vs2017 is not a priority because as long as it still works in vs2013, @CelticMinstrel's workflow for creating releases will remain unaffected.

CelticMinstrel commented

2018-02-25 20:23:52 +00:00

(Migrated from github.com)

I'm not sure what to think of that last commit (tests). I think I'd kinda prefer if it could be done without the stdafx PCH, at least (though I guess it's not that big a deal). Also, I'd leave out the Tests namespace unless Microsoft actually requires it.

For the "your code here" you could either call the main() function or look at the catchorg/Catch2 documentation about how to use Catch without a main(). (Though it looks like our included version is seriously out-of-date now, so I'm not sure if you can find relevant documentation there.)

I'm not sure what to think of that last commit (tests). I think I'd kinda prefer if it could be done without the stdafx PCH, at least (though I guess it's not that big a deal). Also, I'd leave out the Tests namespace unless Microsoft actually requires it. For the "your code here" you could either call the main() function or look at the [catchorg/Catch2](https://github.com/catchorg/Catch2) documentation about how to use Catch without a main(). (Though it looks like our included version is seriously out-of-date now, so I'm not sure if you can find relevant documentation there.)

daerogami (Migrated from github.com) reviewed 2018-02-25 20:24:32 +00:00

rsrc/menus/BladesOfExile.rc

						
				@@ -38,3 +37,4 @@

				IDI_BOESCEN             ICON                    "BoE Scenario.ico"

				/////////////////////////////////////////////////////////////////////////////

				//

daerogami (Migrated from github.com) commented

2018-02-25 20:24:32 +00:00

This might break the vs2013 project, but it will need to be addressed when that one is moved anyways.

This _might_ break the vs2013 project, but it will need to be addressed when that one is moved anyways.

daerogami (Migrated from github.com) reviewed 2018-02-25 20:25:59 +00:00

src/fileio/debugout.win.cpp

						
				@@ -20,2 +18,4 @@

						output_debug_string(this->str().c_str());

						this->str(std::basic_string<CharT>()); // Clear the string buffer

						return 0;

					}

daerogami (Migrated from github.com) commented

2018-02-25 20:25:59 +00:00

Really weird bug preventing me from compilation. Test this in xCode and let me know if it breaks anything.

CelticMinstrel (Migrated from github.com) reviewed 2018-02-25 20:26:22 +00:00

src/fileio/debugout.win.cpp

						
				@@ -20,2 +18,4 @@

						output_debug_string(this->str().c_str());

						this->str(std::basic_string<CharT>()); // Clear the string buffer

						return 0;

					}

CelticMinstrel (Migrated from github.com) commented

2018-02-25 20:26:22 +00:00

That's impossible, this code isn't even used in Xcode. So there's nothing to worry about.

daerogami (Migrated from github.com) reviewed 2018-02-25 20:27:15 +00:00

src/game/boe.graphics.cpp

						
				@@ -33,2 +33,4 @@

				#include "prefs.hpp"

				#ifndef MSBUILD_GITREV

				#include "gitrev.hpp"

				#endif

daerogami (Migrated from github.com) commented

2018-02-25 20:27:14 +00:00

Just a preprocessor that we set if MSBUILD is handling this. Added a NuGet package called "gitinfo" that makes git status related stuff available to preprocessor.

daerogami (Migrated from github.com) reviewed 2018-02-25 20:40:59 +00:00

src/fileio/debugout.win.cpp

						
				@@ -20,2 +18,4 @@

						output_debug_string(this->str().c_str());

						this->str(std::basic_string<CharT>()); // Clear the string buffer

						return 0;

					}

daerogami (Migrated from github.com) commented

2018-02-25 20:40:59 +00:00

Awesome!

daerogami commented

2018-02-25 20:45:35 +00:00

(Migrated from github.com)

@CelticMinstrel The tests project is partially implemented on purpose. Both vs2013 and vs2017 will get MSTEST integration. It will probably be a companion PR built on top of the vs2013 move to proj folder.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: openboe/oboe#176