Address a bunch of dead store issues found by the static analyzer.

Pretty much all of these fall into one of two categories:

* Variables that are obviously unneeded and in many cases completely unused – probably remnants of old code that was rewritten. These ones were deleted.

* Variables that look like they should be used but aren't. These ones have been suppressed, with a TODO message added as a reminder to investigate them in more detail later.
This commit is contained in:
2024-08-10 12:22:05 -04:00
parent 1d491e3b2a
commit f400a5b7de
12 changed files with 28 additions and 35 deletions

View File

@@ -1110,6 +1110,10 @@ void do_sign(short town_num, short which_sign, short sign_type) {
store_sign_mode = sign_type;
pict.setPict(univ.scenario.ter_types[sign_type].picture);
// TODO: Why is town_num unused?
// Seems like it could cause the wrong sign to show sometimes,
// like when you're in one outdoor section viewing a sign in
// an adjacent section
if(town_num >= 200) {
town_num -= 200;
sign_text = univ.out->sign_locs[which_sign].text;
@@ -1117,6 +1121,7 @@ void do_sign(short town_num, short which_sign, short sign_type) {
else {
sign_text = univ.town->sign_locs[which_sign].text;
}
(void) town_num;
sign->getControl("sign").setText(sign_text);
sign.show();