Nuke as many warnings as possible, and several globals as well
- Warnings completely suppressed for the included TinyXML and gzstream libraries - Parentheses warnings are now errors, since there were several that looked like bugs - Ditto for dangling else warnings Some of these warnings were actually bugs: - Town wandering monsters would have never spawned, because the code to do so was accidentally nested within a check for overall_mode == MODE_OUTDOORS ---> boe.monster.cpp, lines 105-137 - Monster's behaviour with respect to elemental fields did not correctly depend on their immunities (this is the same precedence issue Sylae messed up fixing in the Windows code) ---> boe.monsters.cpp, lines 345-359 - Display of damage blocked by armour appeared to be incorrect (needs verification) ---> boe.newgraph.cpp, line 1079 - Three-choice dialogs probably weren't dealing with unusual button types correctly, though that's a minor point since they aren't expected to use such buttons
This commit is contained in:
@@ -175,7 +175,7 @@ rectangle rect(location tl, location br){
|
||||
return rectangle(tl,br);
|
||||
}
|
||||
|
||||
rectangle rect(char top, char left, char bottom, char right){
|
||||
rectangle rect(int top, int left, int bottom, int right) {
|
||||
return rectangle(top, left, bottom, right);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user