openboe/oboe
2
0
Fork 0
Code Issues 146 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix possible buffer overreach when selecting a shop item

Browse Source 
Thanks to @fosnola for the fix.
This commit is contained in:
Celtic Minstrel
2023-01-18 09:56:14 -05:00
parent 20102c7f52
commit 924692c1dd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/game/boe.dlgutil.cpp
View File

@@ -220,7 +220,9 @@ void handle_shop_event(location p) {
}
for(short i = 0; i < 8; i++) {
unsigned long what_picked = shop_array[i + shop_sbar->getPosition()];
auto shop_i = i + shop_sbar->getPosition();
if(shop_i >= shop_array.size()) break;
unsigned long what_picked = shop_array[shop_i];
if(what_picked >= active_shop.size()) break;
if(active_shop.getItem(what_picked).type == eShopItemType::EMPTY)
break;