From 6a34d05ce355932cf03a28ea5a4f7711d9387ced Mon Sep 17 00:00:00 2001 From: Nat Quayle Nelson Date: Tue, 21 Jan 2025 11:52:42 -0600 Subject: [PATCH] Remove warning for spells that use default 1-sq pattern. This fixes #489. I considered an alternate solution of adding a case for every 1-sq-target spell, but there are so many of them. Targeting 1 square is a sensible default, not something that should have to be specified, and this warning would only really be useful when adding new spells to avoid forgetting to specify their shape. I say we don't need it. --- src/game/boe.combat.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/game/boe.combat.cpp b/src/game/boe.combat.cpp index d0e82ba3..8c166421 100644 --- a/src/game/boe.combat.cpp +++ b/src/game/boe.combat.cpp @@ -5185,9 +5185,8 @@ void start_spell_targeting(eSpell num, bool freebie, int spell_range, eSpellPat } break; default: - if((*num).refer == REFER_TARGET) - std::cout << " Warning: Spell " << (*num).name() << " didn't assign target shape." << std::endl; - else add_string_to_buf(" Error: Entered targeting for non-targeted spell " + (*num).name(), 4); + if((*num).refer != REFER_TARGET) + add_string_to_buf(" Error: Entered targeting for non-targeted spell " + (*num).name(), 4); break; } }