Update About Blades of Exile dialog

- Some text in this update contributed by ADoS

Also:
- Make scroll panes scroll 5 pixels per click instead of 1
- Make scroll pane page size depend on the height

rsrc/dialogs/about-boe.xml

@@ -7,15 +7,49 @@
 	<pict type='dlog' num='16' top='6' left='6'/>
 	<text top='6' left='50' width='420' height='33'>
 		Blades of Exile v2.0 alpha <br/>
-		  Copyright 1997-8, Spiderweb Software, Inc., All rights reserved.
+		  Copyright 1997-2015, Spiderweb Software, Inc., All rights reserved.
 	</text>
 	<pane top='42' left='50' width='400' height='67'>
-		<text top='42' left='50' width='400' height='67'>
+		<text size='large' top='42' left='150' width='300' height='10'>------      CREDITS      ------</text>
-			CREDITS: <br/>
+		<!-- TODO: Get a proper right-aligned text setting so that I don't have to use this hack of weird numbers of spaces -->
-			   Concept, Design, Programming: Jeff Vogel <br/>
+		<!-- The height of this text needs to be 10 times the number of lines. -->
-			   Graphics: Andrew Hunter (Wormius@aol.com) <br/>
+		<text top='52' left='50' width='400' height='210'>
-			   Business Manager: Mariann Krizsan (krizsan@spidweb.com)<br/>
+			ORIGINAL GAME: <br/>
-			   Title Screen: James Ernest (ernest@speakeasy.org)
+			   Concept, Design, Programming: <br/>
+			                                          Graphics: <br/>
+			                         Business Manager: <br/>
+			                     Title/Splash Screens: <br/>
+			<br/>
+			OPEN SOURCE CREDITS: <br/>
+			                                   Programming: <br/><br/><br/><br/><br/><br/>
+			                                          Graphics: <br/><br/><br/>
+			         Testing and Troubleshooting: <br/>
+			<br/>
+			SCENARIO FIXES AND UPDATES: <br/>
+			                              Bandit Busywork: <br/>
+		</text>
+		<!-- The height of this text needs to be 10 times the number of lines. -->
+		<!-- Also make sure that it properly aligns with the previous text. -->
+		<!-- Comments are included to aid with this. Don't mess it up! Test it to be sure! -->
+		<text top='52' left='250' width='230' height='210'>
+			<!-- ORIGINAL GAME --><br/>
+			<!-- Concept, Design, Programming -->Jeff Vogel (SpidWeb@spidweb.com) <br/>
+			<!-- Graphics -->Andrew Hunter (Wormius@aol.com) <br/>
+			<!-- Business Manager -->Mariann Krizsan (krizsan@spidweb.com)<br/>
+			<!-- Title/Splash Screens -->James Ernest (ernest@speakeasy.org) <br/>
+			<br/><!-- OPEN SOURCE CREDITS --><br/>
+			<!-- Programming -->Khoth <br/>
+			Ormus <br/>
+			Chokboyz <br/>
+			Celtic Minstrel <br/>
+			Paul Erdos <br/>
+			Sylae Corell <br/>
+			<!-- Graphics -->The Almighty Doer of Stuff <br/>
+			Mistb0rn <br/>
+			Celtic Minstrel <br/>
+			<!-- Testing and Troubleshooting -->The Almighty Doer of Stuff <br/>
+			<br/><!-- SCENARIO FIXES AND UPDATES --><br/>
+			<!-- Bandit Busywork -->The Almighty Doer of Stuff <br/>
 		</text>
 	</pane>
 	<text top='110' left='50' width='410' height='51'>
@@ -24,18 +58,14 @@
 		"Blades of Exile" and Spiderweb Software are trademarks of Spiderweb Software.
 	</text>
 	<text top='162' left='50' width='424' height='145'>
-		Blades of Exile is $30 shareware. For information on how to
+		  Open Blades of Exile is brought to you from the hard work of volunteers who are passionate about this software.
-		register, select 'How To Order' from the game opening screen.
+		We sincerely hope you enjoy, share, and discuss this game, and maybe even make and release your own scenario!<br/>
+		  Open Blades of Exile is a modification of Blades of Exile, created by Spiderweb Software, Inc. in 1997.
+		It is released under GNU GPL 2.0+. The source code can be found at https://github.com/calref/cboe/.
 	</text>
-	<text top='196' left='50' width='354' height='32'>
+	<text top='240' left='60' width='353' height='66'>
-		Comments and questions? The creators of Exile want to hear them.
+		Comments and questions? The creators and maintainers of Exile want to hear them.
-		Send them to:
+		Visit http://www.spidweb.com/, where you can find the official discussion forum and other great games!
 	</text>
-	<!--text top='229' left='60' width='353' height='66'>
-		Internet: SpidWeb@spidweb.com <br/>
-		America Online: SpidWeb <br/>
-		Compuserve: 76463,1521 <br/>
-		WWW: http://www.spidweb.com
-	</text-->
 	<button name='okay' type='regular' top='299' left='435'>OK</button>
 </dialog>

src/boe.main.cpp

@@ -600,8 +600,10 @@ void handle_menu_choice(eMenu item_hit) {
 			give_help(212,0);
 			break;
 	}
-	if(!dialogToShow.empty())
+	if(!dialogToShow.empty()) {
-		cChoiceDlog(dialogToShow).show();
+		cChoiceDlog dlog(dialogToShow);
+		dlog.show();
+	}
 }
 
 //  TODO: Let this function take a cMonster* instead of the item_hit

src/dialogxml/scrollpane.cpp

@@ -59,8 +59,8 @@ void cScrollPane::recalcRect() {
 	globalFrame.inset(-4,-4);
 	frame.left = globalFrame.left;
 	frame.right = globalFrame.right;
-	scroll.setMaximum(globalFrame.height() - frame.height());
+	scroll.setMaximum((globalFrame.height() - frame.height()) / 5);
-	scroll.setPageSize(100);
+	scroll.setPageSize((frame.height() - 5) / 5);
 	rectangle scrollFrame;
 	scrollFrame.left = frame.right;
 	scrollFrame.top = frame.top;
@@ -143,7 +143,7 @@ void cScrollPane::draw() {
 	for(auto& ctrl : contents) {
 		rectangle localBounds = ctrl.second->getBounds();
 		rectangle globalBounds = localBounds;
-		globalBounds.offset(0, -scroll.getPosition());
+		globalBounds.offset(0, -5 * scroll.getPosition());
 		ctrl.second->setBounds(globalBounds);
 		ctrl.second->draw();
 		ctrl.second->setBounds(localBounds);
@@ -184,14 +184,14 @@ std::string cScrollPane::parse(ticpp::Element& who, std::string fname) {
 	if(!foundTop) throw xMissingAttr("pane","top",who.Row(),who.Column(),fname);
 	if(!foundLeft) throw xMissingAttr("pane","left",who.Row(),who.Column(),fname);
 	if(width > 0) {
-		frame.right = frame.left + width;
+		frame.width() = width;
 	}else{
 		throw xMissingAttr("pane","width",who.Row(),who.Column(),fname);
 	}
 	if(height > 0) {
-		frame.bottom = frame.top + height;
+		frame.height() = height;
 	}else{
-		frame.bottom = frame.top + 10;
+		frame.height() = 10;
 	}
 	setBounds(frame);
 	for(node = node.begin(&who); node != node.end(); node++) {