kiss-lang/lime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MacPlatform: running install_name_tool with System.runCommand() works better than new Process()

Browse Source 
new Process() was crashing before the process could start for some reason
This commit is contained in:
Josh Tynjala
2024-05-29 15:57:38 -07:00
parent d3d476a1f5
commit ae941e7442
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/platforms/MacPlatform.hx
View File

@@ -710,23 +710,13 @@ class MacPlatform extends PlatformTarget
if (isLibrary) if (isLibrary)
{ {
var newId = "@executable_path/" + fileName; var newId = "@executable_path/" + fileName;
var process = new Process("install_name_tool", ["-id", newId, absoluteFilePath]); System.runCommand("", "install_name_tool", ["-id", newId, absoluteFilePath]);
var exitCode = process.exitCode(true);
if (exitCode != 0)
{
Log.error('install_name_tool -id process exited with code: <${exitCode}> for file <${fileName}>');
}
} }
for (homebrewPath in homebrewDependencyPaths) for (homebrewPath in homebrewDependencyPaths)
{ {
var newPath = "@executable_path/" + Path.withoutDirectory(homebrewPath); var newPath = "@executable_path/" + Path.withoutDirectory(homebrewPath);
var process = new Process("install_name_tool", ["-change", homebrewPath, newPath, absoluteFilePath]); System.runCommand("", "install_name_tool", ["-change", homebrewPath, newPath, absoluteFilePath]);
var exitCode = process.exitCode(true);
if (exitCode != 0)
{
Log.error('install_name_tool -change process exited with code: <${exitCode}> for file <${Path.withoutDirectory(homebrewPath)}>');
}
} }
} }
} }