From 00fd063026c0ddb72ee57d5c90523e1b407d0c8c Mon Sep 17 00:00:00 2001 From: Joseph Cloutier Date: Sat, 11 Jun 2022 20:08:54 -0400 Subject: [PATCH] Use `implementation` instead of `api`. This is recommended as a best practice, though AFAIK this only matters for projects that are going to be imported by other projects. For instance, you used to be able to include `:deps:extension-api` by including any extension that depended on it. Now, every project that wants to use `extension-api` has to include it directly. (Which is fine because in practice, they all already do so.) --- templates/android/template/app/build.gradle | 4 ++-- templates/android/template/build.gradle | 2 +- templates/extension/dependencies/android/build.gradle | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/android/template/app/build.gradle b/templates/android/template/app/build.gradle index 40aa08b13..d2e5260d6 100644 --- a/templates/android/template/app/build.gradle +++ b/templates/android/template/app/build.gradle @@ -83,8 +83,8 @@ android { } dependencies { - api fileTree(dir: 'libs', include: ['*.jar']) - ::if (ANDROID_LIBRARY_PROJECTS)::::foreach (ANDROID_LIBRARY_PROJECTS)::api project(':deps:::name::') + implementation fileTree(dir: 'libs', include: ['*.jar']) + ::if (ANDROID_LIBRARY_PROJECTS)::::foreach (ANDROID_LIBRARY_PROJECTS)::implementation project(':deps:::name::') ::end::::end:: } diff --git a/templates/android/template/build.gradle b/templates/android/template/build.gradle index 7ffb01761..55388aaba 100644 --- a/templates/android/template/build.gradle +++ b/templates/android/template/build.gradle @@ -58,6 +58,6 @@ configure(subprojects.findAll {!it.file('build.gradle').exists() && it.file('bui } dependencies { - api project(':deps:extension-api') + implementation project(':deps:extension-api') } } diff --git a/templates/extension/dependencies/android/build.gradle b/templates/extension/dependencies/android/build.gradle index f08ae46f6..8b5014f91 100644 --- a/templates/extension/dependencies/android/build.gradle +++ b/templates/extension/dependencies/android/build.gradle @@ -17,5 +17,5 @@ android { } dependencies { - api project(':deps:extension-api') + implementation project(':deps:extension-api') }